Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove containerd proxy config #1

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

bavarianbidi
Copy link

as we do the containerd proxy config via kubeadm and the build-in config overwrite our own config we have to remove it.

Signed-off-by: Mario Constanti [email protected]

as we do the containerd proxy config via kubeadm and the build-in
config overwrite our own config we have to remove it.

Signed-off-by: Mario Constanti <[email protected]>
@erkanerol
Copy link

@bavarianbidi Do we know whether they will remove this from the upstream repo?

@bavarianbidi
Copy link
Author

bavarianbidi commented Nov 8, 2022

@bavarianbidi Do we know whether they will remove this from the upstream repo?

during the last session we had with them, they mentioned that this might be something they want to achieve in the near future to allign with other providers.
I've directly asked in vmware#299 about accepting this commit in upstream repo.

@bavarianbidi bavarianbidi merged commit 38c95db into giantswarm-main Nov 14, 2022
@bavarianbidi bavarianbidi deleted the remove_build_in_httpproxy_config branch November 14, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants